Skip to content

Fix/chromedriver processes#7

Merged
GoWithitRoger merged 2 commits intomainfrom
fix/chromedriver-processes
Aug 11, 2025
Merged

Fix/chromedriver processes#7
GoWithitRoger merged 2 commits intomainfrom
fix/chromedriver-processes

Conversation

@GoWithitRoger
Copy link
Copy Markdown
Owner

No description provided.

…te parsing

- add cleanup_old_processes() to proactively kill lingering chromedriver via pkill
- call cleanup_old_processes() at start of perform_checks() to prevent orphaned drivers
- enhance run_wifi_diagnostics_task(): detect Tx rate across multiple wdutil keys
  (Tx Rate, TxRate, Last Tx Rate, Max PHY Rate)
- keep robust managed_webdriver_session post-run cleanup as secondary safeguard

Tests
- test_cleanup.py: cover pkill invocation and exception handling
- test_main_flow.py: mock cleanup_old_processes; assert it runs first in perform_checks
- test_core.py: parametrize Wi‑Fi Tx rate key variants; maintain existing success/failure cases
- minor import/lint cleanups in tests

Notes
- aligns with acceptance criteria: pre-emptive cleanup logs, no orphaned chromedriver, primary flows intact

Refs
Ticket: Implement Pre-emptive and Post-run Process Cleanup
@GoWithitRoger GoWithitRoger merged commit 08ee061 into main Aug 11, 2025
1 check passed
@GoWithitRoger GoWithitRoger deleted the fix/chromedriver-processes branch August 11, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant